Re: [PATCH 10/17] tty: remove MODULE_LICENSE in non-modules
From: Luis Chamberlain
Date: Tue Mar 28 2023 - 22:50:54 EST
Nick, you *need* something we *want* but the form requires work.
Removing the module license tag and all that other module boiler
plate from modules which cannot possibly be modules is obviously
welcomed. But there's a few issues, one of them is when we don't
have SPDX license pegged on files. We *all* want SPDX files properly
annotated on files. We *want* to automate the module license from
the SPDX tag.
It sounds hard but let's go for the long shot of striving to automate
the module license from the SPDX tags.
Let's break this down into a few steps that also benefit your goals:
1) Fix all all code which use the module license tag but cannot possibly
be modules to ensure they all have proper SPDX tags. This is a welcomed
effort.
2) Create an an association of existing module licenses from mod-objs object
lists.
3) Verify these make sense with us.
4) With that list we can then infer a module license from things which
*can* be modules.
The trick is today we use the module license *for* that inference,
however, look at the tristate, and see if you can add a POSSIBLE_MODULE
as I noted and hinted before. That get's you a module license
replacement. The final nail to all this is use that to replace all
module licenses and have this done automatically.
Luis