Re: [PATCH v3 4/4] of: address: Always use dma_default_coherent for default coherency

From: Michael Ellerman
Date: Tue Mar 28 2023 - 23:27:59 EST


Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> writes:
> As for now all arches have dma_default_coherent reflecting default
> DMA coherency for of devices, so there is no need to have a standalone
> config option.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> ---
> v3: Squash setting ARCH_DMA_DEFAULT_COHERENT into this patch.
> ---
> arch/powerpc/Kconfig | 2 +-
> arch/riscv/Kconfig | 2 +-
> drivers/of/Kconfig | 4 ----
> drivers/of/address.c | 10 +---------
> 4 files changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 57f5d2f53d06..824e00a1277b 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -113,6 +113,7 @@ config PPC
> #
> select ARCH_32BIT_OFF_T if PPC32
> select ARCH_DISABLE_KASAN_INLINE if PPC_RADIX_MMU
> + select ARCH_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE
> select ARCH_ENABLE_MEMORY_HOTPLUG
> select ARCH_ENABLE_MEMORY_HOTREMOVE
> select ARCH_HAS_COPY_MC if PPC64
> @@ -273,7 +274,6 @@ config PPC
> select NEED_PER_CPU_PAGE_FIRST_CHUNK if PPC64
> select NEED_SG_DMA_LENGTH
> select OF
> - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE
> select OF_EARLY_FLATTREE
> select OLD_SIGACTION if PPC32
> select OLD_SIGSUSPEND

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

cheers