Re: [PATCH -next v2] spi: rockchip-sfc: Use devm_platform_ioremap_resource()

[Tudor Ambarus]

On 3/29/23 07:24, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

I still prefer a single patch per subsystem, but Mark is going to decide:

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---
> 
> change in v2:
> --According to Tudor's suggestion, use devm_platform_ioremap_resource() and
>   get rid of the local variable too.
> 
>  drivers/spi/spi-rockchip-sfc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 4fabd2e0439f..b370aade11b4 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -558,7 +558,6 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct spi_master *master;
> -	struct resource *res;
>  	struct rockchip_sfc *sfc;
>  	int ret;
>  
> @@ -576,8 +575,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
>  	sfc = spi_master_get_devdata(master);
>  	sfc->dev = dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sfc->regbase = devm_ioremap_resource(dev, res);
> +	sfc->regbase = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sfc->regbase))
>  		return PTR_ERR(sfc->regbase);
>