Re: [PATCH] dt-bindings: usb: typec-tcpci: convert to DT schema format

From: Krzysztof Kozlowski
Date: Wed Mar 29 2023 - 03:25:10 EST


On 29/03/2023 09:16, Jun Li wrote:
>
> Per spec below, TCPCI does need interrupt for alert, but no limit on the number.
>
> "The TCPC uses I2C to communicate with the TCPM. The TCPC is an I2C slave
> with Alert# signal for requesting attention."
>
>> no supplies and no additional GPIOs (like reset
>> GPIO)?
>
> Those are out of scope of spec, I think it can be added as optional.
>
>>
>> Because this is what this binding is saying.
>>
>>> fully compliance with tcpci spec, if change it to be only specific to
>>> nxp,ptn5110, my understanding is then other chips need duplicate a
>>> binding doc even common tcpci binding and driver is enough for them.
>>
>> Depends. Usually we have common schema used by actual device schemas. If
>> TCPCI-compliant device cannot have additional properties,
>
> My understanding was TCPCI-compliant device can have additional optional
> properties.

Then I propose to rename it to device-matching name (nxp,ptn5110.yaml).
Except interrupt and connector, there is nothing here which describes
actual standard or common class. These can easily be moved to shared
binding later. I can easily imagine TCPCI devices with a bit different
interface and different properties.

Best regards,
Krzysztof