Re: [PATCH 4/5] objtool: Add per-function rate limiting for unreachable warnings

From: Peter Zijlstra
Date: Wed Mar 29 2023 - 03:29:44 EST


On Tue, Mar 28, 2023 at 01:22:05PM -0700, Josh Poimboeuf wrote:
> On Tue, Mar 28, 2023 at 10:11:05AM +0200, Peter Zijlstra wrote:
> > On Mon, Mar 27, 2023 at 09:00:47AM -0700, Josh Poimboeuf wrote:
> > > Unreachable instruction warnings are rate limited to once per object
> > > file. That no longer makes sense for vmlinux validation, which might
> > > have other unreachable instructions lurking in other places. Change it
> > > to once per function.
> >
> > Do we want a negative option to disable this? --no-ratelimit or such?
>
> Per-function rate-limiting is almost always the right thing, personally
> I don't envision needing to disable it.

Ok, fair enough. I'll let you know if I ever come across the need to
disable it :-)