Re: [PATCH 3/6] devicetree: input: cypress,tt21000: fix interrupt type in dts example

From: Linus Walleij
Date: Wed Mar 29 2023 - 04:43:34 EST


On Thu, Mar 23, 2023 at 2:52 PM Maximilian Weigand
<mweigand@xxxxxxxxxxxx> wrote:

> Triggering the interrupt of the IRQ_TYPE_LEVEL_LOW type can lead to
> probing issues with the device for the current driver (encountered on
> the Pine64 PineNote). Basically the interrupt would be triggered before
> certain commands were sent to the device, leading to a race between the
> device responding fast enough and the irq handler fetching a data frame
> from it. Actually all devices currently using the driver already use a
> falling edge trigger.
>
> Signed-off-by: Maximilian Weigand <mweigand@xxxxxxxxxxxx>
> Reviewed-by: Alistair Francis <alistair@xxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij