Re: [PATCH v6 04/12] dt-bindings: reset: nuvoton: add binding for ma35d1 IP reset control

[Jacky Huang]

Dear Stephen,


On 2023/3/29 上午 01:48, Stephen Boyd wrote:
> Quoting Jacky Huang (2023-03-27 19:19:04)
> > +description:
> > +  The system reset controller can be used to reset various peripheral
> > +  controllers in MA35D1 SoC.
> > +
> > +properties:
> > +  compatible:
> > +    const: nuvoton,ma35d1-reset
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  # system reset controller node:
> > +  - |
> > +
> > +    system-management@40460000 {
> > +        compatible = "nuvoton,ma35d1-sys", "syscon", "simple-mfd";
> > +        reg = <0x40460000 0x200>;
> > +
> > +        reset-controller {
> > +            compatible = "nuvoton,ma35d1-reset";
> > +            #reset-cells = <1>;
> > +        };
> This is prescribing driver details to the system-management node. The
> reset-controller node should be removed, the #reset-cells moved up one
> level, and the "nuvoton,ma35d1-sys" should match a driver that registers
> an auxiliary device for reset functionality. Is anything besides child
> nodes like 'reset-controller' using the syscon@40460000?

OK, I will modify it as:

    sys: system-management@40460000 {
        compatible = "nuvoton,ma35d1-sys", "syscon",;
        reg = <0x0 0x40460000 0x0 0x200>;
        #reset-cells = <1>;
        };
    };

And my reset driver will use compatible "nuvoton,ma35d1-sys", instead of 
"nuvoton,ma35d1-reset".
There' no other node like reset-controller.


Best regards,
Jack Huang