Re: [PATCH v2 1/2] ring-buffer: Introducing ring-buffer mapping functions

From: Steven Rostedt
Date: Wed Mar 29 2023 - 08:08:18 EST


On Wed, 29 Mar 2023 07:03:53 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> struct ring_buffer_meta_page_header {
> #if __BITS_PER_LONG == 64
> __u64 entries;
> __u64 overrun;
> #else
> __u32 entries;
> __u32 overrun;
> #endif
> __u32 pages_touched;
> __u32 meta_page_size;
> __u32 reader_page; /* page ID for the reader page */
> __u32 nr_data_pages; /* doesn't take into account the reader_page */
> };
>
> BTW, shouldn't the nr_data_pages take into account the reader page? As it
> is part of the array we traverse isn't it?

Ah, I guess nr_data_pages is the length of the index mapping, not the
array of pages mapped?

-- Steve