Re: [PATCH V2 7/8] vfio/pci: Support dynamic MSI-x

From: Reinette Chatre
Date: Wed Mar 29 2023 - 10:45:18 EST




Thank you very much for the report.

On 3/28/2023 7:48 PM, kernel test robot wrote:
> config: i386-randconfig-a001-20230327 (https://download.01.org/0day-ci/archive/20230329/202303291000.PWFqGCxH-lkp@xxxxxxxxx/config)

This config (and all the other configs in the reports about
implicit declaration of function 'pci_msix_can_alloc_dyn')
has:
# CONFIG_PCI_MSI is not set

Resulting in:

> drivers/vfio/pci/vfio_pci_intrs.c: In function 'vfio_msi_set_vector_signal':
>>> drivers/vfio/pci/vfio_pci_intrs.c:427:21: error: implicit declaration of function 'pci_msix_can_alloc_dyn' [-Werror=implicit-function-declaration]
> 427 | if (msix && pci_msix_can_alloc_dyn(vdev->pdev))
> | ^~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>


because include/linux/pci.h is missing a stub for
pci_msix_can_alloc_dyn() when CONFIG_PCI_MSI is not set.
I'll send a separate fix for that.

Reinette