Re: [PATCH v2 1/6] rust: error: Rename to_kernel_errno() -> to_errno()

From: Martin Rodriguez Reboredo
Date: Wed Mar 29 2023 - 10:48:47 EST


On 3/29/23 09:04, Asahi Lina wrote:
> This is kernel code, so specifying "kernel" is redundant. Let's simplify
> things and just call it to_errno().
>
> Signed-off-by: Asahi Lina <lina@xxxxxxxxxxxxx>
> ---
> rust/kernel/error.rs | 2 +-
> rust/macros/module.rs | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 5b9751d7ff1d..35894fa35efe 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -73,7 +73,7 @@ pub struct Error(core::ffi::c_int);
>
> impl Error {
> /// Returns the kernel error code.
> - pub fn to_kernel_errno(self) -> core::ffi::c_int {
> + pub fn to_errno(self) -> core::ffi::c_int {
> self.0
> }
> }
> diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> index a7e363c2b044..143336543866 100644
> --- a/rust/macros/module.rs
> +++ b/rust/macros/module.rs
> @@ -258,7 +258,7 @@ pub(crate) fn module(ts: TokenStream) -> TokenStream {
> return 0;
> }}
> Err(e) => {{
> - return e.to_kernel_errno();
> + return e.to_errno();
> }}
> }}
> }}
>

Reviewed-by: Martin Rodriguez Reboredo