Re: [PATCH 1/2] drm/amd/display: Remove unused variable 'scl_enable'

[Hamza Mahfooz]

On 3/28/23 18:09, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c: In function ‘dml_rq_dlg_get_dlg_params’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:991:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]
>
> Get rid of it by removing the variable 'scl_enable'.
>
> Signed-off-by: Caio Novais <caionovais@xxxxxx>

Applied, thanks!

> ---
>   .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index d1c2693a2e28..ea4eb66066c4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -988,7 +988,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	double hratio_c;
>   	double vratio_l;
>   	double vratio_c;
> -	bool scl_enable;
>   
>   	unsigned int swath_width_ub_l;
>   	unsigned int dpte_groups_per_row_ub_l;
> @@ -1117,7 +1116,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	hratio_c = scl->hscl_ratio_c;
>   	vratio_l = scl->vscl_ratio;
>   	vratio_c = scl->vscl_ratio_c;
> -	scl_enable = scl->scl_enable;
>   
>   	swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
>   	dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;

--
Hamza