Re: [PATCH 0/2] bio iter improvements

[Phillip Lougher]

On 28/03/2023 17:57, Kent Overstreet wrote:
> On Tue, Mar 28, 2023 at 02:42:28PM +0100, Phillip Lougher wrote:
> > On Mon, Mar 27, 2023 at 7:02 PM Kent Overstreet
> > <kent.overstreet@xxxxxxxxx> wrote:
> > > Small patch series cleaning up/standardizing bio_for_each_segment_all(),
> > > which means we can use the same guts for bio_for_each_folio_all(),
> > > considerably simplifying that code.
> > >
> > > The squashfs maintainer will want to look at and test those changes,
> > > that code was doing some slightly tricky things. The rest was a pretty
> > > mechanical conversion.
> >
> > An eyeball of the changes doesn't bring up anything obviously wrong.
> >
> > I'll apply and do some tests.
> >
> > Phillip
> >
> > BTW please CC me on the cover letter as well as patch [1/2].
>
> Will do.
>
> There were some squashfs files that got missed, there's a fixup patch
> you'll want in this branch:
>
> https://evilpiepirate.org/git/bcachefs.git/log/?h=bio_folio_iter

Patches applied, and I do see some issues in testing.

I'll reply on patch [1/2] because that's where the code is.

Phillip