Re: [acme:tmp.perf-tools-next] [perf build] a980755beb: perf-sanity-tests.perf.make.fail

[Arnaldo Carvalho de Melo]

On March 29, 2023 1:54:39 PM GMT-03:00, Ian Rogers <irogers@xxxxxxxxxx> wrote:
>On Tue, Mar 28, 2023 at 11:17 PM Oliver Sang <oliver.sang@xxxxxxxxx> wrote:
>>
>> hi Ian,
>>
>> On Wed, Mar 22, 2023 at 09:03:28AM -0700, Ian Rogers wrote:
>> > On Wed, Mar 22, 2023 at 7:20 AM kernel test robot <oliver.sang@xxxxxxxxx> wrote:
>> > >
>> > >
>> > > Greeting,
>> > >
>> > > FYI, we noticed perf-sanity-tests.perf.make.fail due to commit (built with gcc-11):
>> > >
>> > > commit: a980755beb5aca9002e1c95ba519b83a44242b5b ("perf build: Make BUILD_BPF_SKEL default, rename to NO_BPF_SKEL")
>> > > https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git tmp.perf-tools-next
>> > >
>> > > in testcase: perf-sanity-tests
>> > > version: perf-x86_64-e8d018dd0257-1_20230320
>> > > with following parameters:
>> > >
>> > >         perf_compiler: clang
>> > >
>> > > [   98.290078][  T246] make perf failed
>> >
>> > Hi Oliver,
>> >
>> > Could we add NO_BPF_SKEL=1 to the build flags? The idea with changing
>> > the default is that is what most users want and so we want the BPF
>> > skeleton to be opt-out rather than opt-in.
>>
>> Thanks a lot for guidance!
>>
>> I added NO_BPF_SKEL=1 then make perf can pass upon this commit.
>> I also tried to add BUILD_BPF_SKEL=1 while make perf for parent, it will fail.
>>
>> since you said in commit message
>> "BPF skeleton support is now key to a number of perf features."
>> we will start to fix make issue.


So, does that mean that you guys will not use NO_BPF_SKEL=1 and instead will try to have what is needed to build with the default: with BPF skel and the features enabled by them?

If that is the case: great!

- Arnaldo 

>>
>> Thanks!
>
>This is great Oliver, many thanks!
>Ian
>
>> >
>> > Thanks,
>> > Ian
>> >
>> > >
>> > > To reproduce:
>> > >
>> > >         git clone https://github.com/intel/lkp-tests.git
>> > >         cd lkp-tests
>> > >         sudo bin/lkp install job.yaml           # job file is attached in this email
>> > >         bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>> > >         sudo bin/lkp run generated-yaml-file
>> > >
>> > >         # if come across any failure that blocks the test,
>> > >         # please remove ~/.lkp and /lkp dir to run from a clean state.
>> > >
>> > >
>> > >
>> > > --
>> > > 0-DAY CI Kernel Test Service
>> > > https://github.com/intel/lkp-tests
>> > >
>> > >
>> >