RE: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus

[Gupta, Nipun]

[AMD Official Use Only - General]


> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, March 29, 2023 3:56 PM
> To: Gupta, Nipun <Nipun.Gupta@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> rafael@xxxxxxxxxx; eric.auger@xxxxxxxxxx; alex.williamson@xxxxxxxxxx;
> cohuck@xxxxxxxxxx; song.bao.hua@xxxxxxxxxxxxx;
> mchehab+huawei@xxxxxxxxxx; maz@xxxxxxxxxx; f.fainelli@xxxxxxxxx;
> jeffrey.l.hugo@xxxxxxxxx; saravanak@xxxxxxxxxx;
> Michael.Srba@xxxxxxxxx; mani@xxxxxxxxxx; yishaih@xxxxxxxxxx;
> jgg@xxxxxxxx; jgg@xxxxxxxxxx; robin.murphy@xxxxxxx; will@xxxxxxxxxx;
> joro@xxxxxxxxxx; masahiroy@xxxxxxxxxx; ndesaulniers@xxxxxxxxxx;
> rdunlap@xxxxxxxxxxxxx; baolu.lu@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kbuild@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; okaya@xxxxxxxxxx;
> Anand, Harpreet <harpreet.anand@xxxxxxx>; Agarwal, Nikhil
> <nikhil.agarwal@xxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>;
> Jansen Van Vuuren, Pieter <pieter.jansen-van-vuuren@xxxxxxx>; Cascon,
> Pablo <pablo.cascon@xxxxxxx>; git (AMD-Xilinx) <git@xxxxxxx>
> Subject: Re: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Mon, Mar 13, 2023 at 06:56:31PM +0530, Nipun Gupta wrote:
> > Add CDX bus to iommu_buses so that IOMMU probe is called
> > for it.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@xxxxxxx>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-
> vuuren@xxxxxxx>
> > Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@xxxxxxx>
> > ---
> >  drivers/iommu/iommu.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 10db680acaed..0025a631b8e1 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -28,6 +28,7 @@
> >  #include <linux/fsl/mc.h>
> >  #include <linux/module.h>
> >  #include <linux/cc_platform.h>
> > +#include <linux/cdx/cdx_bus.h>
> >  #include <trace/events/iommu.h>
> >  #include <linux/sched/mm.h>
> >  #include <linux/msi.h>
> > @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
> >  #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
> >       &host1x_context_device_bus_type,
> >  #endif
> > +#ifdef CONFIG_CDX_BUS
> > +     &cdx_bus_type,
> > +#endif
> >  };
> 
> Note, this prevents the ability for this struct bus_type from being
> moved into read-only memory in the future.  But hopefully that will be
> fixed up eventually, you are in good company with some other busses
> here...
> 
> Other than that, this series looks good, I'll queue this up through my
> tree for now as I seem to collect new subsystems.  Feel free to send
> future patches through me as well until you get tired of that and want
> to send stuff to Linus directly.

Thanks, Greg, for the review and helping get the series in : )

Regards,
Nipun

> 
> thanks,
> 
> greg k-h