Re: [RFC PATCH v2 1/3] vsock: return errors other than -ENOMEM to socket

[Stefano Garzarella]

On Thu, Mar 30, 2023 at 10:05:45AM +0300, Arseniy Krasnov wrote:
> This removes behaviour, where error code returned from any transport
> was always switched to ENOMEM. This works in the same way as:
> commit
> c43170b7e157 ("vsock: return errors other than -ENOMEM to socket"),
> but for receive calls.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@xxxxxxxxxxxxxx>
> ---
> net/vmw_vsock/af_vsock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

We should first make sure that all transports return the right value,
and then expose it to the user, so I would move this patch, after
patch 2.

Thanks,
Stefano

> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
> index 5f2dda35c980..413407bb646c 100644
> --- a/net/vmw_vsock/af_vsock.c
> +++ b/net/vmw_vsock/af_vsock.c
> @@ -2043,7 +2043,7 @@ static int __vsock_stream_recvmsg(struct sock *sk, struct msghdr *msg,
>
> 		read = transport->stream_dequeue(vsk, msg, len - copied, flags);
> 		if (read < 0) {
> -			err = -ENOMEM;
> +			err = read;
> 			break;
> 		}
>
> @@ -2094,7 +2094,7 @@ static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg,
> 	msg_len = transport->seqpacket_dequeue(vsk, msg, flags);
>
> 	if (msg_len < 0) {
> -		err = -ENOMEM;
> +		err = msg_len;
> 		goto out;
> 	}
>
> --
> 2.25.1