Re: [PATCH v6 07/12] dt-bindings: serial: Document ma35d1 uart controller

From: Rob Herring
Date: Thu Mar 30 2023 - 09:12:29 EST


On Thu, Mar 30, 2023 at 06:52:11PM +0800, Jacky Huang wrote:
>
>
> On 2023/3/30 下午 03:33, Krzysztof Kozlowski wrote:
> > On 29/03/2023 10:44, Jacky Huang wrote:
> > > Dear Krzysztof,
> > >
> > >
> > > Thanks for your review.
> > >
> > >
> > > On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote:
> > > > On 28/03/2023 04:19, Jacky Huang wrote:
> > > > > From: Jacky Huang <ychuang3@xxxxxxxxxxx>
> > > > >
> > > > > Add documentation to describe nuvoton ma35d1 uart driver bindings.
> > > > >
> > > > This depends on clock patches, so it must be taken together.
> > > >
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > >
> > > > Best regards,
> > > > Krzysztof
> > > >
> > > OK, I will combine this patch with the clock patch.
> > I don't know what you mean by "combine", but I don't think this is what
> > we want. You must clearly state all dependencies and patch merging
> > strategy/way.
> >
> > Best regards,
> > Krzysztof
> >
>
> Dear Krzysztof,
>
>
> I may be misunderstanding your request.
> I thought it was moving the "nuvoton,ma35d1-serial.yaml" to the patch of
> nuvoton,ma35d1-clk.h.
> Would you please provide guidance what should I do next on this [PATCH v6
> 07/12]. Thank you.

The only combining you should do is putting the 2 patches in the same
series. Combining to 1 patch would be wrong.

Your other option is just drop the header in the example and use the
raw numbers. Then there is no dependency to manage and each subsystem
maintainer can take the relevant patches.

Rob