Re: [PATCH v3 11/17] arm64: dts: mediatek: add usb controller support for mt8365-evk

From: Matthias Brugger
Date: Thu Mar 30 2023 - 13:31:09 EST




On 29/03/2023 15:26, AngeloGioacchino Del Regno wrote:
Il 29/03/23 10:54, Alexandre Mergnat ha scritto:
This patch add support for SuperSpeed USB, in OTG mode, on micro connector.
It also add support for the Extensible Host Controller Interface USB.

Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
---
  arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
index 22ec332fe9c9..868ee0d160e4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
@@ -319,6 +319,28 @@ &pwm {
      status = "okay";
  };
+&ssusb {
+    pinctrl-0 = <&usb_pins>;
+    pinctrl-names = "default";
+    maximum-speed = "high-speed";
+    usb-role-switch;
+    dr_mode = "otg";
+    vusb33-supply = <&mt6357_vusb33_reg>;
+    status = "okay";

Order by name please.

P.S.: status can go at the bottom, even if v < s :-)

You mean v > s ;-)

Yes please reorder keep the status to the bottom that's somehow identical throughout the kernel.

Regards,
Matthias


Thanks,
Angelo