Re: [PATCH net-next 01/15] net: dsa: mt7530: make some noise if register read fails

[Andrew Lunn]

On Thu, Mar 30, 2023 at 04:19:26PM +0100, Daniel Golle wrote:
> Simply returning the negative error value instead of the read value
> doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1)
> so this kind of error will not go unnoticed.
> 
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew