Re: [RESEND] [PATCHv3 4/7] thermal: rockchip: Simplify channel id logic

[Daniel Lezcano]

On 30/03/2023 19:07, Heiko Stübner wrote:
> Am Donnerstag, 16. März 2023, 11:05:25 CEST schrieb Daniel Lezcano:
> > Hi Heiko,
> >
> > On 08/03/2023 19:42, Sebastian Reichel wrote:
> > > Hi Daniel,
> > >
> > > On Wed, Mar 08, 2023 at 07:13:22PM +0100, Daniel Lezcano wrote:
> > > > On 08/03/2023 12:22, Sebastian Reichel wrote:
> > > > > Replace the channel ID lookup table by a simple offset, since
> > > > > the channel IDs are consecutive.
> > > > >
> > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> > > >
> > > > As all the other patches are reviewed by Heiko, is the tag missing here?
> > >
> > > Heiko was not happy with this in PATCHv2, when he reviewed most
> > > of the patches:
> > >
> > > https://lore.kernel.org/all/3601039.e9J7NaK4W3@phil/
> > >
> > > I replied, but never got a response, so I kept it as is:
> > >
> > > https://lore.kernel.org/all/20221206170232.xsm4kcbfwrmlrriw@xxxxxxxxxxxxxxxxxxxxxx/
> > >
> > > FWIW it is essential for the series and cannot be dropped, because
> > > RK3588 has more than 2 channels.
> >
> > Do you have a suggestion to improve the proposed change ?
>
> I guess it's fine after all.
>
> Sebastian's response makes sense and there is not really a reason to keep
> infrastructure around for a hypothetical case that may never happen.
>
> If that really changes with some SoC in the far future we can always
> re-evaluate.

Thanks, I've added your tag


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog