Re: [PATCH] net: wwan: t7xx: do not compile with -Werror by default

From: Jakub Kicinski
Date: Fri Mar 31 2023 - 02:27:32 EST


On Wed, 29 Mar 2023 12:26:39 +0200 Jiri Slaby (SUSE) wrote:
> There is no reason for any code in the kernel to be built with -Werror
> by default. Note that we have generic CONFIG_WERROR. OTOH, some drivers
> may want to do this only on per-driver basis. Some do
> CONFIG_DRM_I915_WERROR or alike. But I reused the scsi's:
> ifdef WARNINGS_BECOME_ERRORS
> approach.
>
> Now, if one wants to build t7xx with -Werror, they may say:
> make WARNINGS_BECOME_ERRORS=1

As you said we have CONFIG_WERROR now, so I'd vote to delete
that line completely.