Re: [RFC PATCH v3 2/4] vsock/vmci: convert VMCI error code to -ENOMEM on receive

[Stefano Garzarella]

On Thu, Mar 30, 2023 at 11:18:36PM +0300, Arseniy Krasnov wrote:
> On 30.03.2023 23:13, Arseniy Krasnov wrote:
> > This adds conversion of VMCI specific error code to general -ENOMEM. It
> > is needed, because af_vsock.c passes error value returned from transport
> > to the user, which does not expect to get VMCI_ERROR_* values.
>
> @Stefano, I have some doubts about this commit message, as it says "... af_vsock.c
> passes error value returned from transport to the user ...", but this
> behaviour is implemented only in the next patch. Is it ok, if both patches
> are in a single patchset?

Yes indeed it is not clear. In my opinion we can do one of these 2
things:

1. Update the message, where we can say that this is a preparation patch
   for the next changes where af_vsock.c will directly return transport
   values to the user, so we need to return an errno.

2. Merge this patch and patch 3 in a single patch.

Both are fine for my point of view, take your choice ;-)

Thanks,
Stefano