Re: [PATCH v3 2/3] drm/bridge: tfp410: Fix logic to configured polled HPD

[Neil Armstrong]

Hi,

On 20/02/2023 23:10, Jonathan Cormier wrote:
> From: Michael Williamson <michael.williamson@xxxxxxxxxxxxxxxx>
>
> The logic to configure polling (vs async/irq notification) of hot-plug
> events was not correct.  If the connected bridge requires polling,
> then inform the upstream bridge we also require polling.
>
> Signed-off-by: Michael Williamson <michael.williamson@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
> ---
>   drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index bb3f8d0ff207..41007d05d584 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge,
>   		return -ENODEV;
>   	}
>   
> -	if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT)
> +	if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD)
>   		dvi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>   	else
>   		dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;

A Fixes tag is probably needed here ?

With that:
Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>