Re: [PATCH v2] crypto: hisilicon/trng - add support for HiSTB TRNG

[Herbert Xu]

On Wed, Mar 22, 2023 at 06:33:26AM +0800, David Yang wrote:
>
> +static int histb_trng_wait(struct hwrng *rng)
> +{
> +	void __iomem *base = (void __iomem *) rng->priv;

You should never need to cast something to __iomem.

Please copy what the meson driver does, that is the right way.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt