Re: [v2] wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

From: Kalle Valo
Date: Fri Mar 31 2023 - 10:54:40 EST


Wei Chen <harperchen1110@xxxxxxxxx> wrote:

> If there is a failure during copy_from_user or user-provided data buffer is
> invalid, rtl_debugfs_set_write_reg should return negative error code instead
> of a positive value count.
>
> Fix this bug by returning correct error code. Moreover, the check of buffer
> against null is removed since it will be handled by copy_from_user.
>
> Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
> Signed-off-by: Wei Chen <harperchen1110@xxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

5dbe1f8eb8c5 wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230326054217.93492-1-harperchen1110@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches