Re: [PATCH v10 1/6] cxl/mbox: Add GET_POISON_LIST mailbox command

[Alison Schofield]

On Thu, Mar 30, 2023 at 03:43:18PM -0700, Dave Jiang wrote:
> 
> 
> On 3/21/23 7:12 PM, alison.schofield@xxxxxxxxx wrote:
> > From: Alison Schofield <alison.schofield@xxxxxxxxx>
> > 
> > CXL devices maintain a list of locations that are poisoned or result
> > in poison if the addresses are accessed by the host.
> > 
> > Per the spec (CXL 3.0 8.2.9.8.4.1), the device returns this Poison
> 
> Maybe you need a comma here?
> 
> > list as a set of  Media Error Records that include the source of the
> 
> extra space between "of" and "Media"
> 
> > error, the starting device physical address and length. The length is
> 
> Should add a comma before "and length".
> 
> > the number of adjacent DPAs in the record and is in units of 64 bytes.
> > 
> > Retrieve the poison list.

FYI - this is v10, but things you are pointing out do apply to v11.
I'll update the commit msg as you suggest.

> > 

snip

> > +
> > +struct cxl_mbox_poison_payload_out {
> > +	u8 flags;
> > +	u8 rsvd1;
> > +	__le64 overflow_t;
> > +	__le16 count;
> > +	u8 rsvd2[20];
> > +	struct cxl_poison_record {
> > +		__le64 address;
> > +		__le32 length;
> > +		__le32 rsvd;
> > +	} __packed record[];
> > +} __packed;
> 
> Pretty long struct name. poison_mbox_in and poison_mbox_out?

Yeah...I'll drop the _payload from each. Thanks!

> 
snip to end.