Re: [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG

From: Herbert Xu
Date: Sat Apr 01 2023 - 04:07:08 EST


On Fri, Mar 31, 2023 at 06:19:34PM +0800, David Yang wrote:
>
> + struct histb_trng_priv *priv = (struct histb_trng_priv *) rng->priv;

Plesae don't use rng->priv at all. We're trying to phase it
out because it encourages horrible casting like this.

Please follow the model used in the meson driver.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt