Re: [PATCH] Revert "venus: firmware: Correct non-pix start and end addresses"

From: Linux regression tracking (Thorsten Leemhuis)
Date: Sun Apr 02 2023 - 01:03:19 EST




On 01.04.23 22:53, Leonard Lausen wrote:
> Hi Javier, Dikshita, Stan,
>
> the revert wasn't applied to v6.2 series. Can you please apply it and include it for v6.2.10?
>
> March 6, 2023 at 5:43 AM, "Javier Martinez Canillas" <javierm@xxxxxxxxxx> wrote:
>>> On 3/1/2023 3:15 PM, Dikshita Agarwal wrote:
>>>> On 2/28/2023 9:33 PM, Javier Martinez Canillas wrote:
>>>>> Javier Martinez Canillas<javierm@xxxxxxxxxx> writes:
>>>>>> Vikash Garodia<vgarodia@xxxxxxxxxxxxxxxx> writes:
>>>>>>
>>>>>>> Stan, could you please help with the revert and a pull request having this revert
>>>>>>> alongwith other pending changes ?
>>>>>>>
>>>>>> Other fix posted is "media: venus: dec: Fix capture formats enumeration order":
>>>>>>
>>>>>> https://patchwork.kernel.org/project/linux-media/patch/20230210081835.2054482-1-javierm@xxxxxxxxxx/
>>>
>>> Hi Javier,
>>>
>>> Thanks for this patch "media: venus: dec: Fix capture formats
>>> enumeration order".
>>>
>>> Somehow I can't find it in my mailbox to be able to reply there.
>>>
>>> Could you please explain what is the regression you see here?
>>>
>>
>> You can find the thread and explanation of the issue here:
>>
>> https://lore.kernel.org/lkml/Y+KPW18o%2FDa+N8UI@xxxxxxxxxx/T/
>>
>> But Stanimir already picked it and sent a PR for v6.3 including it.
>
> While "media: venus: dec: Fix capture formats enumeration order" may have been
> applied to v6.3,

To me it looks like it was submitted[1], but not yet applied even to the
media tree[2] -- while guess, maybe due problems mentioned in[3]? Or am
I missing something?

[1]
https://lore.kernel.org/all/20230329211655.100276-1-stanimir.k.varbanov@xxxxxxxxx/
[2] https://git.linuxtv.org/media_tree.git/log/?h=fixes
[3]
https://lore.kernel.org/all/20230329214310.2503484-1-jenkins@xxxxxxxxxxx/

> this still leaves the regression introduced by "venus:
> firmware: Correct non-pix start and end addresses". As pointed out by Matthias
> Kaehlcke, the commit prevents SC7180 and sc7280 AOSS from entering sleep mode
> during system suspend. This is a serious regression in v6.2 kernel series.

That fix is sitting in the media tree for a while and afaics still
hasn't been sent to Linus (which is needed to get this fixed in 6.2.y).

Mauro, could you maybe take care of that?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.