Re: [PATCH] pktcdvd: simplify the class_pktcdvd logic

From: Greg Kroah-Hartman
Date: Sun Apr 02 2023 - 05:06:17 EST


On Sat, Apr 01, 2023 at 08:25:10PM -0600, Jens Axboe wrote:
> On 3/31/23 10:47 AM, Greg Kroah-Hartman wrote:
> > There is no need to dynamically create and destroy the class_pktcdvd
> > structure, just make it static and remove the memory allocation logic
> > which simplifies and cleans up the logic a lot.
> >
> > Cc: linux-block@xxxxxxxxxxxxxxx
> > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> > Note, I would like to take this through my driver-core tree as it is
> > needed for other struct class cleanup work I have done and am continuing
> > to do there.
>
> I'm going to defer to you on this kind of stuff, so if you think it's
> fine, then go for it.

Thanks! And sorry for sending this twice, I forgot I had previously
sent this a few days prior. Too many patches to juggle over here...

greg k-h