Re: [PATCH v3 0/8] Support ACPI PSP on Hyper-V

From: Borislav Petkov
Date: Sun Apr 02 2023 - 11:44:35 EST


On Fri, Mar 24, 2023 at 06:10:09PM +0100, Jeremi Piotrowski wrote:
> Since the AMD PSP is a privileged device, there is a desire to not have to trust the
> ACPI stack,

And yet you do:

+ err = acpi_parse_aspt(&res[0], &pdata);
+ if (err)
+ return err;

You don't trust the ACPI stack, and yet you're parsing an ACPI table?!?!
You have to make up your mind here.

Btw, you still haven't answered my question about doing:

devm_request_irq(dev, 9, ..)

where 9 is the default ACPI interrupt.

You can have some silly table tell you what to map or you can simply map
IRQ 9 and be done with it. In this second case you can *really* not
trust ACPI because you know which IRQ it is.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette