Re: [RFC PATCH v3] nubus: Don't list slot resources by default

From: Brad Boyer
Date: Mon Apr 03 2023 - 02:18:36 EST


On Sun, Mar 26, 2023 at 02:37:02PM +1100, Finn Thain wrote:
> diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c
> index f70ba58dbc55..d2d2b580f646 100644
> --- a/drivers/nubus/nubus.c
> +++ b/drivers/nubus/nubus.c
> @@ -32,6 +32,12 @@
>
> /* Globals */
>
> +/* This parameter makes slot resources available in procfs. It's deprecated and
> + * disabled by default as procfs is no longer thought to be suitable for that.
> + */
> +bool populate_procfs;
> +module_param(populate_procfs, bool, 0);
> +
> LIST_HEAD(nubus_func_rsrcs);
>
> /* Meaning of "bytelanes":

Would it be better to give this option a name that indicates that it
is for nubus only? These are effectively a global namespace. Other
than this, I don't see any issues.

Brad Boyer
flar@xxxxxxxxxxxxx