Re: [PATCH v1] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes

[Alexandre TORGUE]

Hi Oleksij

On 3/28/23 13:02, Oleksij Rempel wrote:
> On Tue, Mar 28, 2023 at 11:58:34AM +0200, Alexandre TORGUE wrote:
> > Hi Oleksij
> >
> > On 3/23/23 13:32, Oleksij Rempel wrote:
> > > This commit introduces Power over Data Line (PoDL) Power Source
> > > Equipment (PSE) regulator nodes to the PRTT1C devicetree. The addition
> > > of these nodes enables support for PoDL in PRTT1C devices, allowing
> > > power delivery and data transmission over a single twisted pair.
> > >
> > > The new PoDL PSE regulator nodes provide voltage capability information
> > > of the current board design, which can be used as a hint for system
> > > administrators when configuring and managing power settings. This
> > > update enhances the versatility and simplifies the power management of
> > > PRTT1C devices while ensuring compatibility with connected Powered
> > > Devices (PDs).
> > >
> > > After applying this patch, the power delivery can be controlled from
> > > user space with a patched [1] ethtool version using the following commands:
> > >     ethtool --set-pse t1l2 podl-pse-admin-control enable
> > > to enable power delivery, and
> > >     ethtool --show-pse t1l2
> > > to display the PoDL PSE settings.
> > >
> > > By integrating PoDL PSE support into the PRTT1C devicetree, users can
> > > benefit from streamlined power and data connections in their
> > > deployments, improving overall system efficiency and reducing cabling
> > > complexity.
> > >
> > > [1] https://lore.kernel.org/all/20230317093024.1051999-1-o.rempel@xxxxxxxxxxxxxx/
> > >
> > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > > ---
> >
> > Please, fix the introduction of those new yaml validation errors:
> >
> > arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-1: $nodename:0:
> > 'ethernet-pse-1' does not match '^ethernet-pse(@.*)?$'
> >          From schema:
> > /Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml
> > arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-2: $nodename:0:
> > 'ethernet-pse-2' does not match '^ethernet-pse(@.*)?$'
> >          From schema: /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml
>
> Using ethernet-pse@1 will require to use "reg" or "ranges" properties.
> Which makes no sense in this use case. I need to fix the schema instead by
> allowing this patter with following regex: "^ethernet-pse(@.*|-[0-9a-f])*$"
>
> Should I send schema fix together with this patch?

Yes you can. As soon as Rob or Krzysztof review it I'll apply both on 
stm32-next.

Thanks
Alex




> Regards,
> Oleksij