Re: [PATCH] xhci: Free the command allocated for setting LPM if we return early

[Mirsad Goran Todorovac]

On 28.3.2023. 9:57, Mathias Nyman wrote:
> On 28.3.2023 1.25, Mirsad Goran Todorovac wrote:
> > On 27. 03. 2023. 11:50, Mathias Nyman wrote:
> > > The command allocated to set exit latency LPM values need to be freed in
> > > case the command is never queued. This would be the case if there is no
> > > change in exit latency values, or device is missing.
> > >
> > > Fixes: 5c2a380a5aa8 ("xhci: Allocate separate command structures for each LPM command")
> > > Cc: <Stable@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > > ---
> > >   drivers/usb/host/xhci.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> > > index bdb6dd819a3b..6307bae9cddf 100644
> > > --- a/drivers/usb/host/xhci.c
> > > +++ b/drivers/usb/host/xhci.c
> > > @@ -4442,6 +4442,7 @@ static int __maybe_unused xhci_change_max_exit_latency(struct xhci_hcd *xhci,
> > >       if (!virt_dev || max_exit_latency == virt_dev->current_mel) {
> > >           spin_unlock_irqrestore(&xhci->lock, flags);
> > > +        xhci_free_command(xhci, command);
> > >           return 0;
> > >       }
> >
> > After more testing, I can confirm that your patch fixes the leak in the original
> > environment.
>
> Thanks for testing.
> Can I add the tags below to the patch?
>
> Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> Tested-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
>
> Thanks
> Mathias

Sure, thanks for the thought. Sorry, my Thunderbird has hidden your message,
I saw it only on Lore and accidentally.

Regards,
Mirsad

--
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union

Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu