Re: [PATCH v2 4.19/5.4/5.10 1/1] gfs2: Always check inode size of inline inodes

[Greg Kroah-Hartman]

On Fri, Mar 24, 2023 at 11:26:15PM +0300, Fedor Pchelkin wrote:
> From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> 
> commit 70376c7ff31221f1d21db5611d8209e677781d3a upstream.
> 
> Check if the inode size of stuffed (inline) inodes is within the allowed
> range when reading inodes from disk (gfs2_dinode_in()).  This prevents
> us from on-disk corruption.
> 
> The two checks in stuffed_readpage() and gfs2_unstuffer_page() that just
> truncate inline data to the maximum allowed size don't actually make
> sense, and they can be removed now as well.
> 
> Reported-by: syzbot+7bb81dfa9cda07d9cd9d@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> [pchelkin@xxxxxxxxx: adjust the inode variable inside gfs2_dinode_in with
> the format used before upstream commit 7db354444ad8 ("gfs2: Cosmetic
> gfs2_dinode_{in,out} cleanup")]
> Signed-off-by: Fedor Pchelkin <pchelkin@xxxxxxxxx>
> ---
> v2: add missed From: tag

Now queued up, thanks.

greg k-h