Re: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master

From: Kalle Valo
Date: Mon Apr 03 2023 - 09:39:08 EST


Cai Huoqing <cai.huoqing@xxxxxxxxx> wrote:

> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@xxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Patch applied to wireless-next.git, thanks.

5995f7463101 wifi: rtw89: Remove redundant pci_clear_master

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-5-cai.huoqing@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches