Re: [PATCH v2] fs/buffer: Remove redundant assignment to err

From: Matthew Wilcox
Date: Mon Apr 03 2023 - 12:13:33 EST


On Mon, Mar 27, 2023 at 10:10:10AM +0200, Christian Brauner wrote:
>
> On Thu, 23 Mar 2023 10:32:59 +0800, Jiapeng Chong wrote:
> > Variable 'err' set but not used.
> >
> > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read.
> >
> >
>
> Applied to

I think you should exercise extreme care with patches from "Abaci Robot".
It's wrong more often than it's right, and the people interpreting the
output from it do not appear to be experienced programmers.