Re: [PATCH] MIPS: vpe-cmp: remove module owner pointer from struct class usage.

[Greg Kroah-Hartman]

On Mon, Apr 03, 2023 at 05:58:04PM +0200, Thomas Bogendoerfer wrote:
> On Sun, Apr 02, 2023 at 11:05:45AM +0200, Greg Kroah-Hartman wrote:
> > In commit 6e30a66433af ("driver core: class: remove struct module owner
> > out of struct class"), the module owner pointer was removed from struct
> > class, but this was missed for the mips vpe-cmp code due to lack of
> > build testing (and it being burried under a very unused config
> > settings.)  Fix this up by removing the module pointer to resolve the
> > build error.
> > 
> > Note, there are other problems with the driver model usage in this file
> > (static struct device usage, empty device release function, etc.), so it
> > probably could use some good cleaning up, but odds are this driver
> > really isn't used so hopefully it will just be removed entirely someday
> > soon as part of the general "remove unused arches" cleanup that is
> > slowly happening.
> > 
> > Cc: Dengcheng Zhu <dzhu@xxxxxxxxxxxx>
> > Cc: John Crispin <blogic@xxxxxxxxxxx>
> > Cc: Qais Yousef <Qais.Yousef@xxxxxxxxxx>
> > Cc: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> > Cc: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > Cc: linux-mips@xxxxxxxxxxxxxxx
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Link: https://lore.kernel.org/oe-kbuild-all/202304020802.xbRTJKjW-lkp@xxxxxxxxx/
> > Fixes: 6e30a66433af ("driver core: class: remove struct module owner out of struct class")
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  arch/mips/kernel/vpe-cmp.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/mips/kernel/vpe-cmp.c b/arch/mips/kernel/vpe-cmp.c
> > index 92140edb3ce3..4ef7f49a4c6d 100644
> > --- a/arch/mips/kernel/vpe-cmp.c
> > +++ b/arch/mips/kernel/vpe-cmp.c
> > @@ -79,7 +79,6 @@ static void vpe_device_release(struct device *cd)
> >  
> >  static struct class vpe_class = {
> >  	.name = "vpe",
> > -	.owner = THIS_MODULE,
> >  	.dev_release = vpe_device_release,
> >  	.dev_groups = vpe_groups,
> >  };
> > -- 
> > 2.40.0
> 
> I guess this should go the same way as commit 6e30a66433af, therefore
> 
> Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

Thanks, I'll take it through my tree.

greg k-h