Re: [PATCH v2] fs/buffer: Remove redundant assignment to err

From: Jan Kara
Date: Mon Apr 03 2023 - 12:38:28 EST


On Mon 03-04-23 18:10:43, Jan Kara wrote:
> On Thu 23-03-23 10:32:59, Jiapeng Chong wrote:
> > Variable 'err' set but not used.
> >
> > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read.
> >
> > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4589
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
>
> I don't think the patch is quite correct (Christian, please drop it if I'm
> correct). See below:

Ah, sorry. I had too old kernel accidentally checked out. The patch is fine
with current upstream. Sorry for the noise!

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR