Re: [PATCH v3 1/6] dmaengine: idxd: Add enable/disable device IOPF feature

From: Dave Jiang
Date: Mon Apr 03 2023 - 12:57:43 EST




On 4/2/23 10:49 PM, Baolu Lu wrote:
On 3/24/23 8:02 PM, Lu Baolu wrote:
The iommu subsystem requires IOMMU_DEV_FEAT_IOPF must be enabled before
and disabled after IOMMU_DEV_FEAT_SVA, if device's I/O page faults rely
on the IOMMU. Add explicit IOMMU_DEV_FEAT_IOPF enabling/disabling in this
driver.

At present, missing IOPF enabling/disabling doesn't cause any real issue,
because the IOMMU driver places the IOPF enabling/disabling in the path
of SVA feature handling. But this may change.

Reviewed-by: Dave Jiang<dave.jiang@xxxxxxxxx>
Reviewed-by: Fenghua Yu<fenghua.yu@xxxxxxxxx>
Reviewed-by: Kevin Tian<kevin.tian@xxxxxxxxx>
Signed-off-by: Lu Baolu<baolu.lu@xxxxxxxxxxxxxxx>

Hi Dave and Fenghua,

The following iommu patches depends on this one. Can I route it to
Linus through the iommu tree?

Hi Baolu, you'll need an ack from Vinod, who is the dmaengine subsystem maintainer. I have no objections.



Best regards,
baolu