Re: [PATCH] string: implement streq()

From: Andrew Morton
Date: Mon Apr 03 2023 - 17:16:49 EST


On Sat, 1 Apr 2023 20:48:05 +0300 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> Most of the time strcmp() is being used, strings are checked for equality.
> Add wrapper to relay such intent (it is shorter to type, too).
>
> Use
> if (streq(s, "s")) {
> }
> or
> if (!streq(s, "s")) {
> }

Gee, do we really want this? I mean, we all know how strcmp() works,
don't we?

I'm thinking it would be better to remove the various cute little
streq() macros and open-code strcmp(...)==0.