Re: [PATCH 4/7] dt-bindings: iommu: arm,smmu: enable clocks for sa8775p

From: Konrad Dybcio
Date: Mon Apr 03 2023 - 18:38:23 EST




On 3.04.2023 22:41, Rob Herring wrote:
> On Tue, Mar 28, 2023 at 09:36:29PM +0200, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>>
>> The KGSL iommu will require the clocks property to be set. Enable it for
>
> Isn't KGSL the name for QCom's adreno vendor driver? What does that have
> to do with bindings?
It's called "KGSL SMMU" (as opposed to the other "APPS SMMU" (Application
Processor SubSystem) in some places in Qualcommland

Konrad
>
>> sa8775p in the bindings.
>>
>> Cc: Will Deacon <will@xxxxxxxxxx>
>> Cc: Robin Murphy <robin.murphy@xxxxxxx>
>> Cc: Joerg Roedel <joro@xxxxxxxxxx>
>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 807cb511fe18..74d5164ed1e8 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -375,7 +375,6 @@ allOf:
>> - nvidia,smmu-500
>> - qcom,qcm2290-smmu-500
>> - qcom,qdu1000-smmu-500
>> - - qcom,sa8775p-smmu-500
>> - qcom,sc7180-smmu-500
>> - qcom,sc8180x-smmu-500
>> - qcom,sc8280xp-smmu-500
>> --
>> 2.37.2
>>