Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc

[Chen Zhongjin]

On 2023/4/4 2:29, Andi Kleen wrote:
> On 4/2/2023 6:24 PM, Chen Zhongjin wrote:
> > Just ping... Or has profile code already been obsoleted?
>
>
> I think it would be reasonable to remove the locked functions hack 
> since lock profiling can be handled with much better other tools these 
> days.
>
> I wouldn't make it depend on the generic unwinder since such a low 
> level facility is likely better off without complex dependencies that 
> could break.
>
> -Andi
Although now the generic unwinder on x86 is quite stable... I think it's 
acceptable to remove the locked functions unwinding
for !FP case and leave the FP part as is.

I'll send a new patch for this with another bugfix.

Thanks for review and best,
Chen