Re: [PATCH] dt-bindings: watchdog: alphascale-asm9260: convert to DT schema

[hack3r-0m]

Thanks for the feedback, I have incorporated the fixes in the patch. Warnings generated from `checkpatch.pl` script seems to be false positive in this case.

------- Original Message -------
On Tuesday, April 4th, 2023 at 7:51 AM, Om Parikh <hack3r-0m@xxxxxxxxx> wrote:


> Makes alphascale-asm9260 dt bindings adhere to the dt json-schema
> by replacing txt file with yaml file.
> 
> Signed-off-by: Om Parikh hack3r-0m@xxxxxxxxx
> 
> ---
> .../watchdog/alphascale,asm9260-wdt.yaml | 73 +++++++++++++++++++
> .../bindings/watchdog/alphascale-asm9260.txt | 35 ---------
> 2 files changed, 73 insertions(+), 35 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> new file mode 100644
> index 000000000000..ceee5f086e4a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/alphascale,asm9260-wdt.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/alphascale,asm9260-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Alphascale asm9260 Watchdog timer
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +maintainers:
> + - Oleksij Rempel linux@xxxxxxxxxxxxxxxx
> 
> + - Olof Johansson olof@xxxxxxxxx
> 
> +
> +properties:
> + compatible:
> + enum:
> + - alphascale,asm9260-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: source clock, used for tick counter
> + - description: ahb gate
> +
> + clock-names:
> + items:
> + - const: mod
> + - const: ahb
> +
> + interrupts:
> + maxItems: 1
> +
> + resets:
> + items:
> + - description: phandle pointing to the system reset controller with line
> + index for the watchdog.
> +
> + reset-names:
> + items:
> + - const: wdt_rst
> +
> + timeout-sec: true
> +
> + alphascale,mode:
> + description: to specify the reset mode of operation
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [hw, sw, debug]
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/alphascale,asm9260.h>
> 
> + watchdog0: watchdog@80048000 {
> + compatible = "alphascale,asm9260-wdt";
> + reg = <0x80048000 0x10>;
> 
> + clocks = <&acc CLKID_SYS_WDT>, <&acc CLKID_AHB_WDT>;
> 
> + clock-names = "mod", "ahb";
> + interrupts = <55>;
> 
> + timeout-sec = <30>;
> 
> + alphascale,mode = "hw";
> + };
> diff --git a/Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt b/Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt
> deleted file mode 100644
> index 75b265a04047..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/alphascale-asm9260.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Alphascale asm9260 Watchdog timer
> -
> -Required properties:
> -
> -- compatible : should be "alphascale,asm9260-wdt".
> -- reg : Specifies base physical address and size of the registers.
> -- clocks : the clocks feeding the watchdog timer. See clock-bindings.txt
> -- clock-names : should be set to
> - "mod" - source for tick counter.
> - "ahb" - ahb gate.
> -- resets : phandle pointing to the system reset controller with
> - line index for the watchdog.
> -- reset-names : should be set to "wdt_rst".
> -
> -Optional properties:
> -- timeout-sec : shall contain the default watchdog timeout in seconds,
> - if unset, the default timeout is 30 seconds.
> -- alphascale,mode : three modes are supported
> - "hw" - hw reset (default).
> - "sw" - sw reset.
> - "debug" - no action is taken.
> -
> -Example:
> -
> -watchdog0: watchdog@80048000 {
> - compatible = "alphascale,asm9260-wdt";
> - reg = <0x80048000 0x10>;
> 
> - clocks = <&acc CLKID_SYS_WDT>, <&acc CLKID_AHB_WDT>;
> 
> - clock-names = "mod", "ahb";
> - interrupts = <55>;
> 
> - resets = <&rst WDT_RESET>;
> 
> - reset-names = "wdt_rst";
> - timeout-sec = <30>;
> 
> - alphascale,mode = "hw";
> -};
> --
> 2.40.0