Re: Regression: NULL pointer dereference after NFS_V4_2_READ_PLUS (commit 7fd461c47)

From: Krzysztof Kozlowski
Date: Tue Apr 04 2023 - 01:29:57 EST


On 04/04/2023 03:01, Olga Kornievskaia wrote:
> On Mon, Mar 6, 2023 at 12:12 PM Anna Schumaker <schumaker.anna@xxxxxxxxx> wrote:
>>
>> Hi Krzysztof,
>>
>> On Tue, Feb 14, 2023 at 6:02 AM Krzysztof Kozlowski
>> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>>
>>> On 12/02/2023 15:05, Anna Schumaker wrote:
>>>>>> From ac2d6c501dbcdb306480edaee625b5496f1fb4f5 Mon Sep 17 00:00:00 2001
>>>>>> From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
>>>>>> Date: Fri, 10 Feb 2023 15:50:22 -0500
>>>>>> Subject: [PATCH] NFSv4.2: Rework scratch handling for READ_PLUS
>>>>>>
>>>>>
>>>>> Patch is corrupted - maybe mail program reformatted it when sending:
>>>>>
>>>>> Applying: NFSv4.2: Rework scratch handling for READ_PLUS
>>>>> error: corrupt patch at line 12
>>>>> Patch failed at 0001 NFSv4.2: Rework scratch handling for READ_PLUS
>>>>
>>>> That's weird. I wasn't expecting gmail to reformat the patch but I
>>>> guess it did. I've added it as an attachment so that shouldn't happen
>>>> again.
>>>
>>> Still null ptr (built on 420b2d4 with your patch):
>>
>> We're through the merge window and at rc1 now, so I can spend more
>> time scratching my head over your bug again. We've come up with a
>> patch (attached) that adds a bunch of printks to show us what the
>> kernel thinks is going on. Do you mind trying it out and letting us
>> know what gets printed out? You'll need to make sure
>> CONFIG_NFS_V4_2_READ_PLUS is enabled when compiling the kernel.
>
> Hi Krzystof,
>
> Since you are the only one hitting the problem, could you be so kind
> as to help with getting this resolved.
>

My setup is not special. It is regular ARMv7 board using a regular ARMv8
NFS server. Anyway my farm is since some time offline due to relocation
and will be online in June, so I cannot test anything.

Best regards,
Krzysztof