Re: [PATCH] iommu/amd: Fix "Guest Virtual APIC Table Root Pointer" configuration in IRTE

[Kishon VijayAbraham I]

Hi Suravee,

On 4/3/2023 9:59 AM, Suthikulpanit, Suravee wrote:
> Kishon,
>
> On 3/31/2023 1:17 PM, Kishon Vijay Abraham I wrote:
> > commit b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC
> > (de-)activation code") while refactoring guest virtual APIC
> > activation/de-activation code, stored information for 
> > activate/de-activate
> > in "struct amd_ir_data". It used 32-bit integer data type for storing the
> > "Guest Virtual APIC Table Root Pointer" (ga_root_ptr), though the
> > "ga_root_ptr" is actually a 40-bit field in IRTE (Interrupt Remapping
> > Table Entry).
> >
> > This causes interrupts from PCIe devices to not reach the guest in the 
> > case
> > of PCIe passthrough with SME (Secure Memory Encryption) enabled as _SME_
> > bit in the "ga_root_ptr" is lost before writing it to the IRTE.
> >
> > Fix it by using 64-bit data type for storing the "ga_root_ptr".
> >
> > Fixes: b9c6ff94e43a ("iommu/amd: Re-factor guest virtual APIC 
> > (de-)activation code")
> > Cc: stable@xxxxxxxxxxxxxxx # v5.4+
> > Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> > Signed-off-by: Kishon Vijay Abraham I <kvijayab@xxxxxxx>
>
> Please also add
> Reported-by: Alejandro Jimenez <alejandro.j.jimenez@xxxxxxxxxx>

sure, will add it in v2 of this patch.

Regards,
Kishon