Re: [PATCH 8/9] arm64: dts: qcom: qcm2290: Add WCN3990 Wi-Fi node

[Krzysztof Kozlowski]

On 04/04/2023 11:55, Konrad Dybcio wrote:
> 
> 
> On 4.04.2023 08:08, Krzysztof Kozlowski wrote:
>> On 03/04/2023 19:36, Konrad Dybcio wrote:
>>> Add a node for the ATH10K SNoC-managed WCN3990 Wi-Fi.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>> ---
>>
>> We had these talks a lot... All these 3-8 patches should be two patches:
>> 1. SoC DTSI
>> 2. Board DTS.
>>
>> Splitting superficially patchset on initial submission does not make
>> sense. If you sent it in separate patchsets during development - release
>> early, release often - then of course it would be fine. But hoarding
>> patches till everything is ready is not the approach we want (and we
>> made it clear that SM8550 should be the last such platform)
> That wasn't my intention.
> 
> This patchset is "feature-rich", as it piggybacks off of Shawn and Loic
> having submitted the driver parts long long ago and SM6115 being quite
> well-supported (and almost identical to the QCM). Patches 4-8 were not
> "held hostage" waiting for full fat platform enablement, but were
> essentially "copy-paste, adjust, verify" and that does not require a
> lot of manpower or time.. I split them to ease the review (~850 LoC @
> PATCH 3, ~1900 LoC @ PATCH 8).
> 
> In any case, the fact that there's so many features submitted with
> the initial posting is not related to me holding onto them on
> purpose, they were created together, probably within 20 minutes of
> each other.. This should have been posted a long time ago with even
> more things (like regulators), but there's been some communication
> issues with Qualcomm..
> 
> LMK how you want me to proceed with this.

All these 3-8 patches should be two patches. If you have separate PMIC,
then could be three patches.

Best regards,
Krzysztof