Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine storage-class-specifier to static

[Wyes Karny]

On 03 Apr 20:33, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
>   'mode_state_machine' was not declared. Should it be static?
> 
> This variable is only used in one file so it should be static.
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Wyes Karny <wyes.karny@xxxxxxx>
Tested-by: Wyes Karny <wyes.karny@xxxxxxx>

> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
>  	return 0;
>  }
>  
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
>  	[AMD_PSTATE_DISABLE]         = {
>  		[AMD_PSTATE_DISABLE]     = NULL,
>  		[AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,
> -- 
> 2.27.0
>