Re: [RFC PATCH V4 17/17] x86/sev: Remove restrict interrupt injection from SNP_FEATURES_IMPL_REQ

[Tianyu Lan]

On 4/4/2023 8:25 PM, Gupta, Pankaj wrote:
> > Enabled restrict interrupt injection function. Remove MSR_AMD64_
> > SNP_RESTRICTED_INJ from SNP_FEATURES_IMPL_REQ to let kernel boot
> > up with this function.
> > ---
> >   arch/x86/boot/compressed/sev.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/boot/compressed/sev.c 
> > b/arch/x86/boot/compressed/sev.c
> > index d63ad8f99f83..a5f41301a600 100644
> > --- a/arch/x86/boot/compressed/sev.c
> > +++ b/arch/x86/boot/compressed/sev.c
> > @@ -299,7 +299,6 @@ static void enforce_vmpl0(void)
> >    */
> >   #define SNP_FEATURES_IMPL_REQ    (MSR_AMD64_SNP_VTOM |            \
> >                    MSR_AMD64_SNP_REFLECT_VC |        \
> > -                 MSR_AMD64_SNP_RESTRICTED_INJ |        \
>
> Should we update the bit in "SNP_FEATURES_PRESENT" instead?

Nice cath! we should add the bit in the SNP_FEATURES_PRESENT.