Re: [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static

From: Linus Walleij
Date: Tue Apr 04 2023 - 10:09:40 EST

Next message: Paul E. McKenney: "Re: [PATCH rcu 0/20] Further shrink srcu_struct to promote cache locality"
Previous message: Petr Mladek: "Re: semantic: Re: [PATCH printk v1 10/18] printk: nobkl: Add emit function and callback functions for atomic printing"
In reply to: Tom Rix: "[PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Apr 4, 2023 at 2:45 AM Tom Rix <trix@xxxxxxxxxx> wrote:

> smatch reports
> drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
> 'mlxbf3_pmx_funcs' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Obviously correct so patch applied.

Yours,
Linus Walleij

Next message: Paul E. McKenney: "Re: [PATCH rcu 0/20] Further shrink srcu_struct to promote cache locality"
Previous message: Petr Mladek: "Re: semantic: Re: [PATCH printk v1 10/18] printk: nobkl: Add emit function and callback functions for atomic printing"
In reply to: Tom Rix: "[PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]