drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types)
From: kernel test robot
Date: Tue Apr 04 2023 - 12:20:57 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 148341f0a2f53b5e8808d093333d85170586a15d
commit: a050910972bb25152b42ad2e544652117c5ad915 efi/libstub: implement generic EFI zboot
date: 7 months ago
config: arm64-randconfig-s052-20230404 (https://download.01.org/0day-ci/archive/20230405/202304050051.J6m3zd1N-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a050910972bb25152b42ad2e544652117c5ad915
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a050910972bb25152b42ad2e544652117c5ad915
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304050051.J6m3zd1N-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
drivers/firmware/efi/libstub/zboot.c: note: in included file (through drivers/firmware/efi/libstub/../../../../lib/decompress_unxz.c):
>> drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: expected restricted __le32 const [usertype] *p
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: got unsigned int const [usertype] *
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: expected restricted __le32 const [usertype] *p
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: got unsigned int const [usertype] *
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: expected restricted __le32 const [usertype] *p
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: got unsigned int const [usertype] *
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: expected restricted __le32 const [usertype] *p
drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: got unsigned int const [usertype] *
drivers/firmware/efi/libstub/zboot.c:163:1: sparse: sparse: symbol 'efi_zboot_entry' was not declared. Should it be static?
vim +393 drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c
24fa0402a9b6a53 Lasse Collin 2011-01-12 385
24fa0402a9b6a53 Lasse Collin 2011-01-12 386 /* Decode the Stream Header field (the first 12 bytes of the .xz Stream). */
24fa0402a9b6a53 Lasse Collin 2011-01-12 387 static enum xz_ret dec_stream_header(struct xz_dec *s)
24fa0402a9b6a53 Lasse Collin 2011-01-12 388 {
24fa0402a9b6a53 Lasse Collin 2011-01-12 389 if (!memeq(s->temp.buf, HEADER_MAGIC, HEADER_MAGIC_SIZE))
24fa0402a9b6a53 Lasse Collin 2011-01-12 390 return XZ_FORMAT_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 391
24fa0402a9b6a53 Lasse Collin 2011-01-12 392 if (xz_crc32(s->temp.buf + HEADER_MAGIC_SIZE, 2, 0)
24fa0402a9b6a53 Lasse Collin 2011-01-12 @393 != get_le32(s->temp.buf + HEADER_MAGIC_SIZE + 2))
24fa0402a9b6a53 Lasse Collin 2011-01-12 394 return XZ_DATA_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 395
24fa0402a9b6a53 Lasse Collin 2011-01-12 396 if (s->temp.buf[HEADER_MAGIC_SIZE] != 0)
24fa0402a9b6a53 Lasse Collin 2011-01-12 397 return XZ_OPTIONS_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 398
24fa0402a9b6a53 Lasse Collin 2011-01-12 399 /*
24fa0402a9b6a53 Lasse Collin 2011-01-12 400 * Of integrity checks, we support only none (Check ID = 0) and
24fa0402a9b6a53 Lasse Collin 2011-01-12 401 * CRC32 (Check ID = 1). However, if XZ_DEC_ANY_CHECK is defined,
24fa0402a9b6a53 Lasse Collin 2011-01-12 402 * we will accept other check types too, but then the check won't
24fa0402a9b6a53 Lasse Collin 2011-01-12 403 * be verified and a warning (XZ_UNSUPPORTED_CHECK) will be given.
24fa0402a9b6a53 Lasse Collin 2011-01-12 404 */
4f8d7abaa413c34 Lasse Collin 2021-10-11 405 if (s->temp.buf[HEADER_MAGIC_SIZE + 1] > XZ_CHECK_MAX)
4f8d7abaa413c34 Lasse Collin 2021-10-11 406 return XZ_OPTIONS_ERROR;
4f8d7abaa413c34 Lasse Collin 2021-10-11 407
24fa0402a9b6a53 Lasse Collin 2011-01-12 408 s->check_type = s->temp.buf[HEADER_MAGIC_SIZE + 1];
24fa0402a9b6a53 Lasse Collin 2011-01-12 409
:::::: The code at line 393 was first introduced by commit
:::::: 24fa0402a9b6a537e87e38341e78b7da86486846 decompressors: add XZ decompressor module
:::::: TO: Lasse Collin <lasse.collin@xxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests