Re: [PATCH v1 03/11] thermal/drivers/intel_menlow: Remove add_one_attribute

From: Daniel Lezcano
Date: Tue Apr 04 2023 - 14:13:03 EST


On 17/03/2023 19:18, Rafael J. Wysocki wrote:
On Mon, Mar 13, 2023 at 1:35 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:

On 13/03/2023 13:26, Rafael J. Wysocki wrote:
On Mon, Mar 13, 2023 at 11:55 AM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:


Hi,

is this code removal acceptable ?

I'll let you know later this week.

Great, thank you

So it would be acceptable if it had no users, but that's somewhat hard
to establish.

As I wrote in a reply to the RFC version of this, I'd rather make
these attributes depend on a Kconfig option or a module parameter
before removing them completely.

Do you mean we set the default to false and see if there are complaints? If not after awhile, we remove the code ?

[ ... ]

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog